Re: [PATCH net-next V3 3/3] net: add a sysctl to make auto flowlabel consistent

Hi Shaohua,

I love your patch! Yet something to improve:

[auto build test ERROR on net-next/master]

url:    https://github.com/0day-ci/linux/commits/Shaohua-Li/net-fix-flowlabel-inconsistency-in-reset-packet/20171205-072626
config: x86_64-randconfig-x004-201749 (attached as .config)
compiler: gcc-7 (Debian 7.2.0-12) 7.2.1 20171025
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

All errors (new ones prefixed by >>):

   In file included from include/net/cls_cgroup.h:19:0,
                    from net/socket.c:98:
   include/net/sock.h: In function 'sk_rethink_txhash':

quoted

include/net/sock.h:1753:29: error: 'struct net' has no member named 'ipv6'; did you mean 'ipv4'?

     if (sk->sk_txhash && !net->ipv6.sysctl.consistent_auto_flowlabel) {
                                ^~~~
                                ipv4

vim +1753 include/net/sock.h

  1748	
  1749	static inline void sk_rethink_txhash(struct sock *sk)
  1750	{
  1751		struct net *net = sock_net(sk);
  1752	

1753		if (sk->sk_txhash && !net->ipv6.sysctl.consistent_auto_flowlabel) {

  1754			u32 v = prandom_u32();
  1755			sk->sk_txhash = v ?: 1;
  1756		}
  1757	}
  1758	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation