[PATCH] dccp: CVE-2017-8824: use-after-free in DCCP code
DORMANTno replies
From: <hidden>
Date: 2017-12-04 22:09:03
Subsystem:
networking [general], the rest · Maintainers:
"David S. Miller", Eric Dumazet, Jakub Kicinski, Paolo Abeni, Linus Torvalds
Possibly related (same subject, not in this thread)
- 2017-12-05 · Re: [PATCH] dccp: CVE-2017-8824: use-after-free in DCCP code · David Miller <davem@davemloft.net>
- 2017-12-05 · Re: [PATCH] dccp: CVE-2017-8824: use-after-free in DCCP code · Eric Dumazet <hidden>
- 2017-12-05 · [PATCH] dccp: CVE-2017-8824: use-after-free in DCCP code · <hidden>
- 2017-12-05 · Re: [PATCH] dccp: CVE-2017-8824: use-after-free in DCCP code · David Miller <davem@davemloft.net>
- 2017-12-04 · Re: [PATCH] dccp: CVE-2017-8824: use-after-free in DCCP code · Eric Dumazet <hidden>
From: Mohamed Ghannam <redacted> Whenever the sock object is in DCCP_CLOSED state, dccp_disconnect() must free dccps_hc_tx_ccid and dccps_hc_rx_ccid and set to NULL. Signed-off-by: Mohamed Ghannam <redacted> --- net/dccp/proto.c | 5 +++++ 1 file changed, 5 insertions(+)
diff --git a/net/dccp/proto.c b/net/dccp/proto.c
index b68168f..9d43c1f 100644
--- a/net/dccp/proto.c
+++ b/net/dccp/proto.c@@ -259,6 +259,7 @@ int dccp_disconnect(struct sock *sk, int flags) { struct inet_connection_sock *icsk = inet_csk(sk); struct inet_sock *inet = inet_sk(sk); + struct dccp_sock *dp = dccp_sk(sk); int err = 0; const int old_state = sk->sk_state;
@@ -278,6 +279,10 @@ int dccp_disconnect(struct sock *sk, int flags) sk->sk_err = ECONNRESET; dccp_clear_xmit_timers(sk); + ccid_hc_rx_delete(dp->dccps_hc_rx_ccid, sk); + ccid_hc_tx_delete(dp->dccps_hc_tx_ccid, sk); + dp->dccps_hc_rx_ccid = NULL; + dp->dccps_hc_tx_ccid = NULL; __skb_queue_purge(&sk->sk_receive_queue); __skb_queue_purge(&sk->sk_write_queue);
--
2.7.4