Re: [PATCH iproute2 net-next] gre6: add collect metadata support

On Mon, Dec 4, 2017 at 9:26 AM, Gregory Rose [off-list ref] wrote:

On 12/1/2017 3:03 PM, William Tu wrote:

quoted

The patch adds 'external' option to support collect metadata
gre6 tunnel. Example of L3 and L2 gre device:
bash:~# ip link add dev ip6gre123 type ip6gre external
bash:~# ip link add dev ip6gretap123 type ip6gretap external

Hi William,

one question.  Is there ever actually going to be a situation in which an
ipv6 gre tunnel will go from
external to not external?  I'm wondering if the "no external" option is
really needed since default is
no and I'm not sure under what circumstances a tunnel would go from external
to not external.

Thanks,

- Greg

good point. I don't think we should support setting a tunnel from
external to no external at run-time.
Let me remove the "noexternal" description in man page.
Thanks

William