Re: [PATCH net-next resubmit 2/2] net: phy: core: don't disable device interrupts in phy_change
From: David Miller <davem@davemloft.net>
Date: 2017-12-04 15:24:41
From: David Miller <davem@davemloft.net>
Date: 2017-12-04 15:24:41
From: Heiner Kallweit <hkallweit1@gmail.com> Date: Thu, 30 Nov 2017 23:57:00 +0100
If state is not PHY_HALTED I see no need to temporarily disable interrupts on the device. As long as the current interrupt isn't acked on the device no new interrupt can happen anyway. In addition remove a unneeded enabling of interrupts in the state machine when handling state PHY_CHANGELINK. Tested on a Odroid-C2 with RTL8211F phy in interrupt mode. Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Also applied, and again if this regresses things I'm reverting.