Thread (1 message) 1 message, 1 author, 2017-11-15
DORMANTno replies

Re: [PATCH v3 2/4] net: nb8800: Simplify nb8800_pause_config()

From: Måns Rullgård <hidden>
Date: 2017-11-15 15:36:22
Also in: linux-arm-kernel

Marc Gonzalez [off-list ref] writes:
On 15/11/2017 16:03, Andrew Lunn wrote:
quoted
On Wed, Nov 15, 2017 at 03:33:47PM +0100, Marc Gonzalez wrote:
quoted
On 15/11/2017 15:17, Andrew Lunn wrote:

In our local branch, I have completely disabled flow control support,
so I don't have to worry about this problem.
That is an interesting statement. You now know there is an issue here,
your solution is to fix your private branch and leave mainline as is.
All my patches are NACKed, what would you have me do?

Moreover, mainline still has the nb8800_dma_stop() work-around,
which Mans has never seen hang.
Here's the thing, if that trick doesn't work, then the dma queue filling
up from real traffic will also hang the controller, which is a much
bigger problem.  Your test today suggests that this might be the case.

-- 
Måns Rullgård
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help