Re: [PATCH 11/17] cls_bpf: Convert to use idr_alloc_u32

From: Matthew Wilcox <willy@infradead.org>
Date: Wed, 29 Nov 2017 08:29:16 -0800

On Tue, Nov 28, 2017 at 05:08:40PM -0800, Jakub Kicinski wrote:

quoted

On Tue, 28 Nov 2017 13:33:06 -0800, Matthew Wilcox wrote:

quoted

+		ret = idr_alloc_u32(&head->handle_idr, prog, &handle,
+						INT_MAX, GFP_KERNEL);
+	} else if (!oldprog) {
+		ret = idr_alloc_u32(&head->handle_idr, prog, &handle,
+						handle, GFP_KERNEL);

nit: in many places you seem to not align the second line with opening
parenthesis.  Is that intentional?

It's more that I don't care.  I press 'enter', which indents the arguments
by a certain amount, then press the 'tab' key until it looks aesthetically
pleasing.

quoted

FWIW there may be a small merge conflict with net on cls_bpf in patch
5, some of the code has been removed.

Thanks.  Dave, do you want to take the IDR patches through your tree to
save conflict resolution?

Sure, after you fix the indentation problems Jakub pointed out please
resubmit them separately to netdev.