Re: [PATCH] net: stmmac: dwmac-sun8i: fix allwinner,leds-active-low handling
From: Andrew Lunn <hidden>
Date: 2017-11-28 17:38:40
Also in:
linux-arm-kernel, lkml
From: Andrew Lunn <hidden>
Date: 2017-11-28 17:38:40
Also in:
linux-arm-kernel, lkml
On Tue, Nov 28, 2017 at 05:48:22PM +0100, Corentin Labbe wrote:
The driver expect "allwinner,leds-active-low" to be in PHY node, but the binding doc expect it to be in MAC node. Since all board DT use it also in MAC node, the driver need to search allwinner,leds-active-low in MAC node.
Hi Corentin I'm having trouble working out how this worked before. This is code you moved around, when adding external/internal MDIOs. But the very first version of this driver code used priv->plat->phy_node. Did that somehow point to the MAC node when the internal PHY is used? Or has it been broken all the time? Andrew