Re: [PATCH 2/2] [RFC] packet: experimental support for 64-bit timestamps

From
Jiri Pirko <jiri@resnulli.us>
Date
2017-11-27 16:59:52
Also in
linux-kselftest, lkml
Reply to
Arnd Bergmann, 2017-11-27
Mon, Nov 27, 2017 at 05:19:25PM CET, arnd@arndb.de wrote:
I tried to figure out what it would take to do a version 4 mmap packet
socket interface to completely avoid the y2106 overflow problem. This is
what I came up with, reusing most of the v3 code, except for the parts
where we access the timestamps.

For kselftest, I'm adding support for testing v4 in addition to v1-v3,
but the test currently does not look at the timestamps, so it won't
check that the timestamp format actually works as intended, only that
I didn't break the parts that worked in the v3 selftest.

Overall, this is more of a mess than I expected, so it's probably not
worth doing a v4 format just for the timestamp, but the patch can serve
as a reference for anyone that needs a new format for other reasons and
fixes this along with the other changes.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
[...]

quoted hunk ↗ jump to hunk
@@ -250,7 +269,8 @@ struct tpacket_block_desc {
enum tpacket_versions {
	TPACKET_V1,
	TPACKET_V2,
-	TPACKET_V3
+	TPACKET_V3,
+	TPACKET_V4,
I wonder with how many versions are we going to eventually end up with :O
Thread (25 messages) 25 messages, 5 authors, last reply 2017-11-30
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help