Re: kernel BUG at crypto/asymmetric_keys/public_key.c:80
From: Johannes Berg <johannes@sipsolutions.net>
Date: 2017-11-24 07:56:41
Also in:
linux-wireless, lkml
Subsystem:
802.11 (including cfg80211/nl80211), the rest · Maintainers:
Johannes Berg, Linus Torvalds
Possibly related (same subject, not in this thread)
- 2017-11-23 · Re: kernel BUG at crypto/asymmetric_keys/public_key.c:80 · Florian Fainelli <f.fainelli@gmail.com>
- 2017-11-23 · Re: kernel BUG at crypto/asymmetric_keys/public_key.c:80 · Johannes Berg <johannes@sipsolutions.net>
- 2017-11-22 · Re: kernel BUG at crypto/asymmetric_keys/public_key.c:80 · Florian Fainelli <f.fainelli@gmail.com>
- 2017-11-22 · Re: kernel BUG at crypto/asymmetric_keys/public_key.c:80 · Johannes Berg <johannes@sipsolutions.net>
- 2017-11-22 · Re: kernel BUG at crypto/asymmetric_keys/public_key.c:80 · Arend van Spriel <arend.vanspriel@broadcom.com>
On Thu, 2017-11-23 at 09:47 -0800, Florian Fainelli wrote:
Absolutely, please find it enclosed.
Thanks.
This is a bit odd. I didn't think the most likely reason is that you
have
CONFIG_CRYPTO_SHA256=m
but everything else built-in. Thus, when loading the certificate,
there's no way to calculate the digest since that requires sha-256,
hence
BUG_ON(!sig->digest);
If you make CONFIG_CRYPTO_SHA256=y then it should go away.
I guess I'll do this:
diff --git a/net/wireless/Kconfig b/net/wireless/Kconfig
index da91bb547db3..1abcc4fc4df1 100644
--- a/net/wireless/Kconfig
+++ b/net/wireless/Kconfig@@ -20,6 +20,10 @@ config CFG80211 tristate "cfg80211 - wireless configuration API" depends on RFKILL || !RFKILL select FW_LOADER + # may need to update this when certificates are changed and are + # using a different algorithm, though right now they shouldn't + # (this is here rather than below to allow it to be a module) + select CRYPTO_SHA256 if CFG80211_USE_KERNEL_REGDB_KEYS ---help--- cfg80211 is the Linux wireless LAN (802.11) configuration API. Enable this if you have a wireless device.
@@ -113,6 +117,9 @@ config CFG80211_EXTRA_REGDB_KEYDIR certificates like in the kernel sources (net/wireless/certs/) that shall be accepted for a signed regulatory database. + Note that you need to also select the correct CRYPTO_<hash> modules + for your certificates, and if cfg80211 is built-in they also must be. + config CFG80211_REG_CELLULAR_HINTS bool "cfg80211 regulatory support for cellular base station hints" depends on CFG80211_CERTIFICATION_ONUS
Can you try if that fixes your config for you? johannes