Re: [PATCH 2/4] btrfs: make open_ctree error injectable
From: Ingo Molnar <mingo@kernel.org>
Date: 2017-11-18 07:05:32
Also in:
linux-btrfs, lkml
* Josef Bacik [off-list ref] wrote:
quoted hunk ↗ jump to hunk
From: Josef Bacik <redacted> This allows us to do error injection with BPF for open_ctree. Signed-off-by: Josef Bacik <redacted> --- fs/btrfs/disk-io.c | 2 ++ 1 file changed, 2 insertions(+)diff --git a/fs/btrfs/disk-io.c b/fs/btrfs/disk-io.c index dfdab849037b..c6b4e1f07072 100644 --- a/fs/btrfs/disk-io.c +++ b/fs/btrfs/disk-io.c@@ -31,6 +31,7 @@ #include <linux/uuid.h> #include <linux/semaphore.h> #include <asm/unaligned.h> +#include <asm/kprobes.h> #include "ctree.h" #include "disk-io.h" #include "hash.h"@@ -3283,6 +3284,7 @@ int open_ctree(struct super_block *sb, goto fail_block_groups; goto retry_root_backup; } +BPF_ALLOW_ERROR_INJECTION(open_ctree);
Ok, this looks a lot better - except the random header inclusion dependency: if a facility is in the BPF_*() namespace then it should include <linux/bpf.h> and not a random asm/* header... With that detail fixed: Acked-by: Ingo Molnar [off-list ref] for the whole series. Thanks, Ingo