Thread (2 messages) flat view 2 messages, 2 authors, 2017-11-08

Re: [PATCH net] qmi_wwan: Add missing skb_reset_mac_header-call

From: David Miller <davem@davemloft.net>
Date: 2017-11-08 07:12:06
Also in: lkml

From: Kristian Evensen <redacted>
Date: Tue,  7 Nov 2017 13:47:56 +0100
When we receive a packet on a QMI device in raw IP mode, we should call
skb_reset_mac_header() to ensure that skb->mac_header contains a valid
offset in the packet. While it shouldn't really matter, the packets have
no MAC header and the interface is configured as-such, it seems certain
parts of the network stack expects a "good" value in skb->mac_header.

Without the skb_reset_mac_header() call added in this patch, for example
shaping traffic (using tc) triggers the following oops on the first
received packet:
 ...
While the oops is for a 4.9-kernel, I was able to trigger the same oops with
net-next as of yesterday.

Signed-off-by: Kristian Evensen <redacted>
Applied, with Fixes: tag added, and queued up for -stable.

Thanks!
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help