Re: [PATCH] wan: wanxl: remove redundant assignment to stat
From: walter harms <hidden>
Date: 2017-11-01 10:50:27
Also in:
kernel-janitors, lkml
Am 01.11.2017 09:49, schrieb Colin King:
quoted hunk ↗ jump to hunk
From: Colin Ian King <redacted> stat set to zero and the value is never read, instead stat is set again in the do-loop. Hence the setting to zero is redundant and can be removed. Cleans up clang warning: drivers/net/wan/wanxl.c:737:2: warning: Value stored to 'stat' is never read Signed-off-by: Colin Ian King <redacted> --- drivers/net/wan/wanxl.c | 1 - 1 file changed, 1 deletion(-)diff --git a/drivers/net/wan/wanxl.c b/drivers/net/wan/wanxl.c index 0c7317520ed3..d573a57bc301 100644 --- a/drivers/net/wan/wanxl.c +++ b/drivers/net/wan/wanxl.c@@ -734,7 +734,6 @@ static int wanxl_pci_init_one(struct pci_dev *pdev, return -ENODEV; } - stat = 0; timeout = jiffies + 5 * HZ; do { if ((stat = readl(card->plx + PLX_MAILBOX_5)) != 0)
it is std. practice to have the pattern: a=b; if (a == c) ... maybe that can be done also here. stat = readl(card->plx + PLX_MAILBOX_5); if ( stat != 0) just a hint. re, wh