Thread (2 messages) 2 messages, 1 author, 2017-11-30

Re: [PATCH] net: ethernet: ixp4xx_eth: Use dma_pool_zalloc

From: Gomonovych, Vasyl <hidden>
Date: 2017-11-30 21:32:11

Sorry, Ignore this please.

On Thu, Nov 30, 2017 at 10:22 PM, Vasyl Gomonovych [off-list ref] wrote:
quoted hunk ↗ jump to hunk
Replacing dma_pool_alloc and memset with a single call to dma_pool_zalloc

Signed-off-by: Vasyl Gomonovych <redacted>
---
 drivers/net/ethernet/xscale/ixp4xx_eth.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/net/ethernet/xscale/ixp4xx_eth.c b/drivers/net/ethernet/xscale/ixp4xx_eth.c
index aee55c03def0..02f7f3e3da8d 100644
--- a/drivers/net/ethernet/xscale/ixp4xx_eth.c
+++ b/drivers/net/ethernet/xscale/ixp4xx_eth.c
@@ -1108,10 +1108,10 @@ static int init_queues(struct port *port)
                        return -ENOMEM;
        }

-       if (!(port->desc_tab = dma_pool_alloc(dma_pool, GFP_KERNEL,
-                                             &port->desc_tab_phys)))
+       port->desc_tab = dma_pool_zalloc(dma_pool, GFP_KERNEL,
+                                        &port->desc_tab_phys);
+       if (!port->desc_tab)
                return -ENOMEM;
-       memset(port->desc_tab, 0, POOL_ALLOC_SIZE);
        memset(port->rx_buff_tab, 0, sizeof(port->rx_buff_tab)); /* tables */
        memset(port->tx_buff_tab, 0, sizeof(port->tx_buff_tab));

--
1.9.1


-- 
Доброї вам пори дня.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help