Re: [PATCH 0/9] use network namespace for iSCSI control interfaces

On Wed, Nov 08, 2017 at 10:31:04AM +0000, David Laight wrote:

From: Chris Leech

quoted

Sent: 07 November 2017 22:45

I've posted these changes to allow iSCSI management within a container
using a network namespace to the SCSI and Open-iSCSI lists, but seeing
as it's not really SCSI/block related I'm casting a wider net looking
for reviews.

I didn't spot you acquiring and releasing references to the namespace.
(I might have missed it, the relevant patch is difficult to read).

If the sockets are created in the context of the process whose namespace
you are using you don't need it, but given the hooks and callbacks
I'm not at all sure that is obviously true.

Thanks David,

Looking at it again, you're right and I think I need to hold a reference
for the iSCSI host and handle namespace deletion.  Even for iscsi_tcp
the socket gets handed off from the creating process to the transport
and can outlive iscsid.

I'm looking at migration or destruction now rather than later.

Chris