Re: [REGRESSION] Warning in tcp_fastretrans_alert() of net/ipv4/tcp_input.c
From: Oleksandr Natalenko <hidden>
Date: 2017-11-10 13:15:04
Possibly related (same subject, not in this thread)
- 2017-09-21 · Re: [REGRESSION] Warning in tcp_fastretrans_alert() of net/ipv4/tcp_input.c · Yuchung Cheng <hidden>
- 2017-09-21 · Re: [REGRESSION] Warning in tcp_fastretrans_alert() of net/ipv4/tcp_input.c · Roman Gushchin <hidden>
- 2017-09-19 · Re: [REGRESSION] Warning in tcp_fastretrans_alert() of net/ipv4/tcp_input.c · Yuchung Cheng <hidden>
- 2017-09-19 · Re: [REGRESSION] Warning in tcp_fastretrans_alert() of net/ipv4/tcp_input.c · Oleksandr Natalenko <hidden>
- 2017-09-19 · Re: [REGRESSION] Warning in tcp_fastretrans_alert() of net/ipv4/tcp_input.c · Oleksandr Natalenko <hidden>
Hi. I'm running the machine with this patch applied for 7 hours now, and the warning hasn't appeared yet. Typically, it should be there within the first hour. I'll keep an eye on it for a longer time, but as of now it looks good. Some explanation on this please? Thanks! 06.11.2017 23:27, Yuchung Cheng wrote: ...snip...
quoted hunk ↗ jump to hunk
hi guys can you try if the warning goes away w/ this quick fix?diff --git a/net/ipv4/tcp_input.c b/net/ipv4/tcp_input.c index 0ada8bfc2ebd..072aab2a8226 100644 --- a/net/ipv4/tcp_input.c +++ b/net/ipv4/tcp_input.c@@ -2626,7 +2626,7 @@ void tcp_simple_retransmit(struct sock *sk) tcp_clear_retrans_hints_partial(tp); - if (prior_lost == tp->lost_out) + if (!tp->lost_out) return; if (tcp_is_reno(tp))
...snip...