Re: [net 3/6] net/mlx5: FPGA, return -EINVAL if size is zero

On Fri, Nov 10, 2017 at 3:13 PM, Saeed Mahameed [off-list ref] wrote:

On Thu, 2017-11-09 at 18:12 +0900, Or Gerlitz wrote:

quoted

On Thu, Nov 9, 2017 at 4:43 PM, Kamal Heib [off-list ref]
wrote:

quoted

On Wed, 2017-11-08 at 23:13 +0900, Or Gerlitz wrote:

quoted

On Wed, Nov 8, 2017 at 4:21 PM, Saeed Mahameed <saeedm@mellanox.c
om>
wrote:

quoted

From: Kamal Heib <redacted>

In the current code, if a size of zero is passed to
mlx5_fpga_mem_{read|write}_i2c() functions the "err"

Don't we need to fix the call site where zero size is provided
and
not
in called function?

Isn't sending down a zero size a sign for a bug which we are not
fixing?

quoted

Both functions are called from an exported symbols. so I think the
size
validation should be within this two functions just like the case
of
checking that mdev isn't set.

mmm, I see exported to who exactly? how are they being called, by
func pointer?
can you point to the call sites?

Or, are you ok with this patch ? I would like to post V2 with the
reviewed-by tag fix.

The RB tag issue was on another patch.. for this patch I realized after talking
to the author that it comes to fix a build warning. I would be happy
if we can clarify
that in the change log.