Re: [PATCH net-next 3/4] net: phy: sfp: Separate enumerations and states
From: Florian Fainelli <f.fainelli@gmail.com>
Date: 2017-11-10 04:40:44
On 11/08/2017 12:58 AM, Russell King - ARM Linux wrote:
On Tue, Nov 07, 2017 at 07:49:10PM -0800, Florian Fainelli wrote:quoted
Create separate enumerations for the SFP physical state (computed from GPIOs), device state, module state, and actual state machine. This will make it easier to make sure the correct states are used, and also pretty print those to help debugging.The compiler does no type checking of these, so I don't see how it makes it any "easier to make sure the correct states are used".
The types currently used (unsigned char, unsigned short) do not make it easy to spot what the enumeration is about and what values could be valid. Overall it seems to me like this improves code readability if nothing else. -- Florian