Thread (38 messages) 38 messages, 9 authors, 2017-11-09

Re: [PATCH v3 net-next 0/5] IGMP snooping for local traffic

From: Vivien Didelot <hidden>
Date: 2017-11-09 14:44:13

Hi David,

David Miller [off-list ref] writes:
From: David Miller <davem@davemloft.net>
Date: Thu, 09 Nov 2017 11:30:32 +0900 (KST)
quoted
Series applied, with the spurious whitespace change removed from patch
#5.
Actually I had to revert, this doesn't build:

net/dsa/slave.c: In function ‘dsa_slave_port_obj_add’:
net/dsa/slave.c:311:26: warning: passing argument 1 of ‘dsa_port_mdb_add’ discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers]
   err = dsa_port_mdb_add(dp->cpu_dp, SWITCHDEV_OBJ_PORT_MDB(obj),
                          ^~
In file included from net/dsa/slave.c:26:0:
net/dsa/dsa_priv.h:150:5: note: expected ‘struct dsa_port *’ but argument is of type ‘const struct dsa_port *’
 int dsa_port_mdb_add(struct dsa_port *dp,
     ^~~~~~~~~~~~~~~~
net/dsa/slave.c: In function ‘dsa_slave_port_obj_del’:
net/dsa/slave.c:340:26: warning: passing argument 1 of ‘dsa_port_mdb_del’ discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers]
   err = dsa_port_mdb_del(dp->cpu_dp, SWITCHDEV_OBJ_PORT_MDB(obj));
                          ^~
In file included from net/dsa/slave.c:26:0:
net/dsa/dsa_priv.h:153:5: note: expected ‘struct dsa_port *’ but argument is of type ‘const struct dsa_port *’
 int dsa_port_mdb_del(struct dsa_port *dp,
     ^~~~~~~~~~~~~~~~
  C-c C-cmake[3]: *** [scripts/Makefile.build:320: drivers/net/team/team.o] Interrupt
This patch series is passing cpu_dp to dsa_port_mdb_* which is const.
I have sent a revert patch to net-next to make it non-const again, so
patch series like this can be applied without compile error.


Thanks,

        Vivien
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help