Thread (6 messages) 6 messages, 2 authors, 2017-11-08

Re: [PATCH net-next 2/3] ip6_gre: Refactor ip6gre xmit codes

From: William Tu <hidden>
Date: 2017-11-08 13:07:38

On Tue, Nov 7, 2017 at 6:10 PM, David Miller [off-list ref] wrote:
From: William Tu <redacted>
Date: Sun,  5 Nov 2017 10:39:04 -0800
quoted
diff --git a/net/ipv6/ip6_gre.c b/net/ipv6/ip6_gre.c
index 3e10c51e7e0c..8c7612f32926 100644
--- a/net/ipv6/ip6_gre.c
+++ b/net/ipv6/ip6_gre.c
@@ -497,6 +497,79 @@ static int gre_handle_offloads(struct sk_buff *skb, bool csum)
                                      csum ? SKB_GSO_GRE_CSUM : SKB_GSO_GRE);
 }

+static inline void prepare_ip6gre_xmit_ipv4(struct sk_buff *skb,
+                                         struct net_device *dev,
+                                         struct flowi6 *fl6, __u8 *dsfield,
+                                         int *encap_limit)
Please do not use 'inline' in foo.c files, let the compiler decide.

Thank you.
Thanks. I will remove it and submit v2.
William
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help