Re: [PATCH net-next v6 3/3] act_vlan: VLAN action rewrite to use RCU lock/unlock and update

Hi Dave,

On Wed, Nov 8, 2017 at 6:40 AM, Manish Kurup [off-list ref] wrote:

Hi Dave,

On Tue, Nov 7, 2017 at 7:07 PM, David Miller [off-list ref] wrote:

quoted

From: Alexander Duyck <redacted>
Date: Tue, 7 Nov 2017 08:54:20 -0800

quoted

Are we really going to be so strict about the reverse xmas-tree that
we won't allow for assignment w/ variable declaration because the
dependency order won't fit into that format?

Yes.

quoted

Last I knew this kind of setup was an exception to the reverse
xmas-tree layout requirement because in this case 'p' relies on 'v' so
we can't reorder these without having to kick the assignment of 'p'
off onto a line by itself.

Please just declare the variable naked without the assignment and do
the assignment down in the code.

I have a changeset that I had made to incorporate the reverse xmas tree,
doing the very thing you talk about, above.
The only reason I didnt not send it out because it made more than minimal
changes, especially how the 'opt' struct is defined.

I will make the changes and send the review around once more.

Thanks,

I have made the required changes, and sent the review around once more
(v10). Please let me know if this looks OK.

Thanks!

-Manish