Re: [PATCH] ipv6: esp6: use BUG_ON instead of if condition followed by BUG
From: Herbert Xu <herbert@gondor.apana.org.au>
Date: 2017-10-25 04:08:40
Also in:
lkml
On Tue, Oct 24, 2017 at 11:28:26AM -0500, Gustavo A. R. Silva wrote:
quoted hunk ↗ jump to hunk
Use BUG_ON instead of if condition followed by BUG in esp_remove_trailer. This issue was detected with the help of Coccinelle. Signed-off-by: Gustavo A. R. Silva <redacted> --- net/ipv6/esp6.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)diff --git a/net/ipv6/esp6.c b/net/ipv6/esp6.c index 89910e2..603ff06 100644 --- a/net/ipv6/esp6.c +++ b/net/ipv6/esp6.c@@ -483,8 +483,7 @@ static inline int esp_remove_trailer(struct sk_buff *skb) goto out; } - if (skb_copy_bits(skb, skb->len - alen - 2, nexthdr, 2)) - BUG(); + BUG_ON(skb_copy_bits(skb, skb->len - alen - 2, nexthdr, 2));
How about ret = skb_copy_bits(skb, skb->len - alen - 2, nexthdr, 2); BUG_ON(ret); Thanks, -- Email: Herbert Xu [off-list ref] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt