Re: [PATCH] rds: Fix inaccurate accounting of unsignaled wrs

On 10/24/2017 9:15 AM, Håkon Bugge wrote:

quoted

On 24 Oct 2017, at 18:05, Santosh Shilimkar 
<santosh.shilimkar-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org <mailto:santosh.shilimkar-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>> 
wrote:

[...]

quoted

Instead of partially doing changes inside/outside helper,
can also add inline helper for solicited state like
rds_ib_set_wr_solicited_state() and use that along
with this change.

Why? There is no book-keeping associated with setting send-solicited. 
Its set on the last fragment of a message and on the last fragment sent 
before throttling due to flow-control.

Creating a function to perform:

         FOO |= BAR;

seems like an overkill to me.

Its just inline helper and keep code consistent for flag
manipulation. Compiler output will be like "FOO =| BAR;" :-)

That being said, in my opinion the fragments of a (large) send should be 
scattered with send-solicited. But that is another commit. But with such 
a commit, I agree with you, a helper function is required.

We already talked about it so lets leave it there.

Regards,
Santosh
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html