Thread (6 messages) flat view 6 messages, 2 authors, 2017-10-24

Re: [PATCH net 3/3] net: mvpp2: do not call txq_done from the Tx path when Tx irqs are used

From: David Miller <davem@davemloft.net>
Date: 2017-10-24 09:35:07
Also in: lkml

From: Antoine Tenart <redacted>
Date: Mon, 23 Oct 2017 15:24:31 +0200
When Tx IRQs are used, txq_bufs_free() can be called from both the Tx
path and from NAPI poll(). This led to CPU stalls as if these two tasks
(Tx and Poll) are scheduled on two CPUs at the same time, DMA unmapping
operations are done on the same txq buffers.

This patch adds a check not to call txq_done() from the Tx path if Tx
interrupts are used as it does not make sense to do so.

Fixes: edc660fa09e2 ("net: mvpp2: replace TX coalescing interrupts with hrtimer")
Signed-off-by: Antoine Tenart <redacted>
Applied.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help