RE: [PATCH v2 3/6] staging: fsl-dpaa2/ethsw: Add ethtool support

-----Original Message-----
From: Andrew Lunn [mailto:andrew@lunn.ch]
Sent: Monday, October 02, 2017 18:37
To: Razvan Stefanescu <redacted>
Cc: gregkh@linuxfoundation.org; devel@driverdev.osuosl.org; linux-
kernel@vger.kernel.org; netdev@vger.kernel.org; agraf@suse.de;
arnd@arndb.de; Alexandru Marginean [off-list ref];
Bogdan Purcareata [off-list ref]; Ruxandra Ioana Radulescu
[off-list ref]; Laurentiu Tudor [off-list ref];
stuyoder@gmail.com
Subject: Re: [PATCH v2 3/6] staging: fsl-dpaa2/ethsw: Add ethtool support

Hi Razvan

quoted

+static void ethsw_get_drvinfo(struct net_device *netdev,
+			      struct ethtool_drvinfo *drvinfo)
+{
+	struct ethsw_port_priv *port_priv = netdev_priv(netdev);
+	u16 version_major, version_minor;
+	int err;
+
+	strlcpy(drvinfo->driver, KBUILD_MODNAME, sizeof(drvinfo->driver));
+	strlcpy(drvinfo->version, ethsw_drv_version, sizeof(drvinfo->version));

Software driver versions are mostly useless. I would suggest you
remove this.

       Andrew

Thank you. I'll remove it in v3.

Best regards,
Razvan S.