On Tue, 31 Oct 2017 10:16:05 -0400
Manish Kurup [off-list ref] wrote:
Hi Pieter,
On Tue, Oct 31, 2017 at 9:06 AM, Pieter Jansen van Vuuren <
pieter.jansenvanvuuren@netronome.com> wrote:
quoted
On Sun, 29 Oct 2017 04:47:54 -0400
Manish Kurup [off-list ref] wrote:
quoted
Using a spinlock in the VLAN action causes performance issues when the
VLAN
quoted
action is used on multiple cores. Rewrote the VLAN action to use RCU read
locking for reads and updates instead.
Fixed nxp flower action to use VLAN helper functions instead of
accessing the
quoted
structure directly (build break error).
Thank you Manish. One minor nit, I think you meant nfp flower action...
Also is it possible to split this patch into 2 patches, it seems to do 2
things:
1. Update the VLAN action to use RCU.
2. Fix the nfp flower action to use the VLAN helper.
Can you please dump the build break error you are seeing here?
...
Here's what the kbuild robot sent me (follows this mail).
I cannot split this into 2 patches, since this has to be part of a patch
I'd sent out for review earlier (the one that fixe the act_vlan action).
Please let me know if you agree with my changes, and I will go ahead and
commit this.
Thanks,
-Manish
Thanks Manish. I don't see obvious issues with this patch. The changes to nfp
flower action could exist standalone without your other patches, no? If that is
the case I would prefer having them split into 2 patches but keep them part of
your patch set. But I guess this is not crucial. Also the build break error
mentioned only occurs after your patches are applied. I would reword the commit
message to "update nfp flower action to use VLAN helper accessing the structure
directly.". The original commit message made me think there might be an bug in
net.
...