Thread (8 messages) 8 messages, 3 authors, 2017-11-01

Re: [Patch net 00/16] net_sched: fix races with RCU callbacks

From: Jamal Hadi Salim <jhs@mojatatu.com>
Date: 2017-10-31 11:00:25

Possibly related (same subject, not in this thread)

On 17-10-31 01:44 AM, Cong Wang wrote:
On Mon, Oct 30, 2017 at 6:03 PM, Lucas Bates [off-list ref] wrote:
quoted
On Oct 30, 2017 19:13, "Cong Wang" [off-list ref] wrote:
quoted
quoted hunk ↗ jump to hunk
Can you try this patch? From your stack trace it is not clear where
the cause is, but we know that the crash is in __tcf_idr_release(),
this is how I came up with the following patch:

diff --git a/include/net/act_api.h b/include/net/act_api.h
index b944e0eb93be..5072446d5f06 100644
--- a/include/net/act_api.h
+++ b/include/net/act_api.h
@@ -122,7 +122,9 @@ void tcf_idrinfo_destroy(const struct tc_action_ops *ops,

  static inline void tc_action_net_exit(struct tc_action_net *tn)
  {
+       rtnl_lock();
         tcf_idrinfo_destroy(tn->ops, tn->idrinfo);
+       rtnl_unlock();
         kfree(tn->idrinfo);
  }
Looks like an excellent bet;-> tdc kills the container at the end of the
test.

cheers,
jamal
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help