On Fri, Oct 27, 2017 at 5:06 PM, Jiri Pirko [off-list ref] wrote:

Fri, Oct 27, 2017 at 10:54:06PM CEST, steven.lin1@broadcom.com wrote:

quoted

Adding DEVLINK_PERM_CONFIG_SRIOV_ENABLED permanent config
parameter.  Value is permanent, so becomes the new default

Avoid the double space.

Ok.

quoted

value for this device.

 DEVLINK_PERM_CONFIG_DISABLE = Disable SR-IOV
 DEVLINK_PERM_CONFIG_ENABLE  = Enable SR-IOV

Signed-off-by: Steve Lin <redacted>
Acked-by: Andy Gospodarek <redacted>
---
include/uapi/linux/devlink.h | 14 +++++++++++++-
net/core/devlink.c           |  1 +
2 files changed, 14 insertions(+), 1 deletion(-)

diff --git a/include/uapi/linux/devlink.h b/include/uapi/linux/devlink.h
index b3a0b2a..9a41f6e 100644
--- a/include/uapi/linux/devlink.h
+++ b/include/uapi/linux/devlink.h

@@ -256,8 +256,20 @@ enum devlink_dpipe_header_id {
      DEVLINK_DPIPE_HEADER_IPV6,

};

-/* Permanent config parameters */
+enum devlink_perm_config_enabled {
+      DEVLINK_PERM_CONFIG_DISABLE,
+      DEVLINK_PERM_CONFIG_ENABLE,
+};
+
+/* Permanent config parameters:
+ * DEVLINK_PERM_CONFIG_SRIOV_ENABLED: Configures whether SR-IOV PCI capability
+ * provided by device.

I don't understand the sentense :/

It means that this parameter controls whether the device advertises
SR-IOV PCI capability -- perhaps I should say "advertised" rather than
"provided"?  Ok, will do that...

quoted

+ *   DEVLINK_PERM_CONFIG_DISABLE = disable SR-IOV
+ *   DEVLINK_PERM_CONFIG_ENABLE  = enable SR-IOV

These comments should be at the enum values, not here.

Ok.

quoted

+ */
enum devlink_perm_config_param {
+      DEVLINK_PERM_CONFIG_SRIOV_ENABLED,
+
      __DEVLINK_PERM_CONFIG_MAX,
      DEVLINK_PERM_CONFIG_MAX = __DEVLINK_PERM_CONFIG_MAX - 1
};

diff --git a/net/core/devlink.c b/net/core/devlink.c
index a7fa7cc..395c93c 100644
--- a/net/core/devlink.c
+++ b/net/core/devlink.c

@@ -1569,6 +1569,7 @@ static int devlink_nl_cmd_eswitch_set_doit(struct sk_buff *skb,

static const struct nla_policy devlink_nl_policy[DEVLINK_ATTR_MAX + 1];

static const u8 devlink_perm_cfg_param_types[DEVLINK_PERM_CONFIG_MAX + 1] = {
+      [DEVLINK_PERM_CONFIG_SRIOV_ENABLED] = NLA_U8,
};

static int devlink_nl_single_param_get(struct sk_buff *msg,
--
2.7.4