Re: [patch net-next v2 00/20] net: sched: convert cls ndo_setup_tc offload calls to per-block callbacks

On 10/24/2017 10:02 AM, Or Gerlitz wrote:

On Tue, Oct 24, 2017 at 7:24 PM, Alexander Duyck
<alexander.duyck@gmail.com <mailto:alexander.duyck@gmail.com>> wrote:

    On Tue, Oct 24, 2017 at 9:01 AM, Alexander Duyck
    <alexander.duyck@gmail.com <mailto:alexander.duyck@gmail.com>> wrote:

 

    > We are getting internal reports of regressions being seen with this
    > patch set applied. Specifically the issues below have been pointed out
    > to me. My understanding is that these issues are all being reported on
    > ixgbe:
    >
    > 1.       To offload filter into HW, the hw-tc-offload feature flag has
    > to be turned on before creating the ingress qdisc.

 

    > 2.       Deleting the ingress qdisc fails to remove filters added in
    > HW. Filters in SW gets deleted.



FWIW, I don't think this is what you're hitting, but please note there
are two  fixes 
to the series in net-next 

9d452ce net/sched: Fix actions list corruption when adding offloaded tc
flows

It looks like this patch just got applied, this fix wasn't included
during our testing.

0843c09 net/sched: Set the net-device for egress device instance

This fix was already in place during our testing. Also, the filters
added were matching on IPv4 addresses with action drop.

I had to looked on other stuff today, but I will keep stressing see
if/what is broken w.r.t mlx5 
and help to get things to work later this and next week so by netdev
we'll be fine

Or.