RE: [patch net 0/4] net/sched: Fix a system panic when deleting filters

Hi Jamal,

-----Original Message-----
From: Jamal Hadi Salim [mailto:jhs@mojatatu.com]
Sent: Monday, October 16, 2017 7:06 PM
To: Chris Mi <redacted>; netdev@vger.kernel.org
Cc: lucasb@mojatatu.com; xiyou.wangcong@gmail.com; jiri@resnulli.us;
davem@davemloft.net
Subject: Re: [patch net 0/4] net/sched: Fix a system panic when deleting
filters


Hi Chris,

On 17-10-16 04:31 AM, Chris Mi wrote:

quoted

If some filters share the same action, when deleting these filters,
system may panic. This patchset fixes this issue. And the test case
finding this issue is also integrated into tc test suite of selftests.

I think this would read better if re-worded as:
---
If some filters share the same action, when deleting these filters, it is
possible to create a system panic. This is because deletions could be
manipulated by many RCU callbacks at the same time.
This patch set fixes these issues.
To reproduce the issue run selftests in patch 3 and 4.
To test if the issue was fixed, apply patches 1 and 2 and then repeat the tests.
------

Done.

Other than that all look good to me and:

Acked-by: Jamal Hadi Salim <jhs@mojatatu.com>

Done. And thanks for your review.

Thanks,
Chris

cheers,
jamal