Re: [PATCH net-next] net: core: decouple ifalias get/set from rtnl lock
From: David Miller <davem@davemloft.net>
Date: 2017-10-02 05:46:45
From: Florian Westphal <fw@strlen.de> Date: Fri, 29 Sep 2017 13:21:50 +0200
quoted hunk ↗ jump to hunk
@@ -1488,7 +1484,7 @@ static void netdev_release(struct device *d) BUG_ON(dev->reg_state != NETREG_RELEASED); - kfree(dev->ifalias); + kfree(rcu_access_pointer(dev->ifalias)); netdev_freemem(dev); }
"kfree_rcu()" at least? If the deal is that you don't need to do and RCU free because netdevice objects disappear synchronously, and you can therefore prove that no RCU based async access can occur to dev->ifalias, then you need to add a comment here.