Thread (2 messages) flat view 2 messages, 2 authors, 2017-10-01

Re: [PATCH net v1 1/1] tipc: use only positive error codes in messages

From: David Miller <davem@davemloft.net>
Date: 2017-10-01 03:04:36

From: Parthasarathy Bhuvaragan <redacted>
Date: Fri, 29 Sep 2017 10:02:54 +0200
In commit e3a77561e7d32 ("tipc: split up function tipc_msg_eval()"),
we have updated the function tipc_msg_lookup_dest() to set the error
codes to negative values at destination lookup failures. Thus when
the function sets the error code to -TIPC_ERR_NO_NAME, its inserted
into the 4 bit error field of the message header as 0xf instead of
TIPC_ERR_NO_NAME (1). The value 0xf is an unknown error code.

In this commit, we set only positive error code.

Fixes: e3a77561e7d32 ("tipc: split up function tipc_msg_eval()")
Signed-off-by: Parthasarathy Bhuvaragan <redacted>
Applied and queued up for -stable, thanks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help