Re: [PATCH V2] r8152: add Linksys USB3GIGV1 id

Hi,

On Thu, Sep 28, 2017 at 3:28 PM, Rustad, Mark D [off-list ref] wrote:

quoted

On Sep 27, 2017, at 9:39 AM, Grant Grundler [off-list ref] wrote:

On Wed, Sep 27, 2017 at 12:15 AM, Oliver Neukum [off-list ref] wrote:

quoted

Am Dienstag, den 26.09.2017, 08:19 -0700 schrieb Doug Anderson:

quoted

I know that for at least some of the adapters in the CDC Ethernet
blacklist it was claimed that the CDC Ethernet support in the adapter
was kinda broken anyway so the blacklist made sense.  ...but for the
Linksys Gigabit adapter the CDC Ethernet driver seems to work OK, it's
just not quite as full featured / efficient as the R8152 driver.

Is that not a concern?  I guess you could tell people in this
situation that they simply need to enable the R8152 driver to get
continued support for their Ethernet adapter?

Hi,

yes, it is a valid concern. An #ifdef will be needed.

Good idea - I will post V3 shortly.

I'm assuming you mean to add #ifdef CONFIG_USB_RTL8152 around the
blacklist entry in cdc_ether driver.

Shouldn't that be an #if IS_ENABLED(...) test, since that seems to be the proper way to check configured drivers.

Yes, I had the same feedback on v3.  See my comments at
<https://patchwork.kernel.org/patch/9974485/>.  Grant has fixed it in
v4.  Please see <https://patchwork.kernel.org/patch/9976657/>.  :)

-Doug