Thread (2 messages) flat view 2 messages, 2 authors, 2017-09-28

Re: [PATCH] isdn/eicon: do integrity check on cmd->adapter == a->controller early

From: David Miller <davem@davemloft.net>
Date: 2017-09-28 16:32:25
Also in: lkml

From: Meng Xu <redacted>
Date: Sun, 24 Sep 2017 11:14:41 -0400
+		/* do the integrity check early */
+		if(((diva_xdi_um_cfg_cmd_t *)data)->adapter != a->controller){
+			DBG_ERR(("A: A(%d) write, invalid controller=%d != %d",
+						((diva_xdi_um_cfg_cmd_t *)data)->adapter, a->controller));
+
DBG_ERR() has a trailing semicolon in it's definition, so if you add
another one when you invoke it there will be two ";;".

This whole code base is such a mess, I really think there is little
to no value in trying to make minor changes here.

So unless you are fixing some kind of exploitable hole, please drop
this.

Thank you.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help