Re: [PATCH v4 7/9] rocker: fix rocker_tlv_put_* functions for KASAN
From: David Miller <davem@davemloft.net>
Date: 2017-09-26 03:19:49
Also in:
linux-kbuild, linux-media, linux-wireless, lkml, stable
From: Arnd Bergmann <arnd@arndb.de> Date: Fri, 22 Sep 2017 23:29:18 +0200
Inlining these functions creates lots of stack variables that each take 64 bytes when KASAN is enabled, leading to this warning about potential stack overflow: drivers/net/ethernet/rocker/rocker_ofdpa.c: In function 'ofdpa_cmd_flow_tbl_add': drivers/net/ethernet/rocker/rocker_ofdpa.c:621:1: error: the frame size of 2752 bytes is larger than 1536 bytes [-Werror=frame-larger-than=] gcc-8 can now consolidate the stack slots itself, but on older versions we get the same behavior by using a temporary variable that holds a copy of the inline function argument. Cc: stable@vger.kernel.org Link: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=81715 Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Applied.