Thread (7 messages) 7 messages, 3 authors, 2017-09-23

Re: [PATCH 0/3] fix reuseaddr regression

From: Josef Bacik <josef@toxicpanda.com>
Date: 2017-09-23 00:28:49
Also in: lkml

On Tue, Sep 19, 2017 at 01:50:56PM -0700, David Miller wrote:
From: josef@toxicpanda.com
Date: Mon, 18 Sep 2017 12:28:54 -0400
quoted
I introduced a regression when reworking the fastreuse port stuff that allows
bind conflicts to occur once a reuseaddr socket successfully opens on an
existing tb.  The root cause is I reversed an if statement which caused us to
set the tb as if there were no owners on the socket if there were, which
obviously is not correct.

Dave I have follow up patches that will add a selftest for this case and I ran
the other reuseport related tests as well.  These need to go in pretty quickly
as it breaks kvm, I've marked them for stable.  Sorry for the regression,
First, please fix your "From: " field so that it actually has your full
name rather than just your email address.  This matter when I apply
your patches.

Second, remove the stable CC:.  For networking changes, you simply ask
me to queue the changes up for -stable.
Sorry Dave, I've fixed my git email settings and I droped the stable cc and sent
a new round.  Didn't see this until just now, my bad.

Josef
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help