Re: [PATCH] wireless: iwlegacy: make const array static to shink object code size Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit
From: Kalle Valo <hidden>
Date: 2017-09-22 10:32:42
Also in:
kernel-janitors, linux-wireless, lkml
Possibly related (same subject, not in this thread)
- 2017-09-22 · Re: [PATCH] wireless: iwlegacy: make const array static to shink object code size Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit · Julia Lawall <hidden>
- 2017-09-22 · Re: [PATCH] wireless: iwlegacy: make const array static to shink object code size Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit · Joe Perches <joe@perches.com>
- 2017-09-22 · Re: [PATCH] wireless: iwlegacy: make const array static to shink object code size Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit · Julia Lawall <hidden>
- 2017-09-22 · Re: [PATCH] wireless: iwlegacy: make const array static to shink object code size Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit · Colin Ian King <hidden>
- 2017-09-22 · Re: [PATCH] wireless: iwlegacy: make const array static to shink object code size Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit · Joe Perches <joe@perches.com>
Stanislaw Gruszka [off-list ref] writes:
On Thu, Sep 21, 2017 at 11:56:30PM +0100, Colin King wrote:quoted
From: Colin Ian King <redacted> Don't populate const array ac_to_fifo on the stack in an inlined function, instead make it static. Makes the object code smaller by over 800 bytes: text data bss dec hex filename 159029 33154 1216 193399 2f377 4965-mac.o text data bss dec hex filename 158122 33250 1216 192588 2f04c 4965-mac.o (gcc version 7.2.0 x86_64) Signed-off-by: Colin Ian King <redacted>Content type information was added at the end of the topic, but I think Kalle can fix that when he will be committing the patch.
Yeah, I'll fix that when I commit this. But very good that you pointed it out, I might miss stuff like this. I'll also remove the "wireless:" prefix from the title. -- Kalle Valo