Thread (11 messages) flat view 11 messages, 3 authors, 2017-09-19

Re: [PATCH net-next 3/4] net: dsa: setup master ethtool after dsa_ptr

From: Florian Fainelli <f.fainelli@gmail.com>
Date: 2017-09-19 17:50:00
Also in: lkml

On 09/19/2017 08:56 AM, Vivien Didelot wrote:
DSA overrides the master's ethtool ops so that we can inject its CPU
port's statistics. Because of that, we need to setup the ethtool ops
after the master's dsa_ptr pointer has been assigned, not before.
Yes, good point, technically this is a bugfix, but since we have changed
this quite often and the race is tiny, I am not positive we could a)
trigger this in real life, and b) provide a proper Fixes tag.
This patch setups the ethtool ops after dsa_ptr is assigned, and
restores them before it gets cleared.

Signed-off-by: Vivien Didelot <redacted>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
-- 
Florian
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help