[PATCH] net_sched: use explicit size of struct tcmsg, remove need to declare tcm · Colin King <hidden> · 2017-09-18
RE: [PATCH] net_sched: use explicit size of struct tcmsg, remove need to declare tcm · David Laight <hidden> · 2017-09-18
Re: [PATCH] net_sched: use explicit size of struct tcmsg, remove need to declare tcm · Eric Dumazet <hidden> · 2017-09-18
RE: [PATCH] net_sched: use explicit size of struct tcmsg, remove need to declare tcm · David Laight <hidden> · 2017-09-18
Re: [PATCH] net_sched: use explicit size of struct tcmsg, remove need to declare tcm · David Miller <davem@davemloft.net> · 2017-09-18

RE: [PATCH] net_sched: use explicit size of struct tcmsg, remove need to declare tcm

From: David Laight <hidden>
Date: 2017-09-18 15:10:44
Also in: kernel-janitors, lkml

From: Eric Dumazet

Sent: 18 September 2017 16:01

...

quoted

quoted

-	err = nlmsg_parse(nlh, sizeof(*tcm), tca, TCA_MAX, NULL, NULL);
+	err = nlmsg_parse(nlh, sizeof(struct tcmsg), tca, TCA_MAX, NULL, NULL);

Would sizeof(*nlmsg_data(nlh)) be cleaner??

Not really, since

static inline void *nlmsg_data(const struct nlmsghdr *nlh)

I thought about that after posting :-(

	David