Thread (2 messages) flat view 2 messages, 2 authors, 2017-09-08

Re: [PATCH] isdn: isdnloop: fix logic error in isdnloop_sendbuf

From: David Miller <davem@davemloft.net>
Date: 2017-09-08 03:04:32
Also in: lkml

From: Arnd Bergmann <arnd@arndb.de>
Date: Wed,  6 Sep 2017 15:38:58 +0200
gcc-7 found an ancient bug in the loop driver, leading to a condition that
is always false, meaning we ignore the contents of 'card->flags' here:

drivers/isdn/isdnloop/isdnloop.c:412:37: error: ?: using integer constants in boolean context, the expression will always evaluate to 'true' [-Werror=int-in-bool-context]

This changes the braces in the expression to ensure we actually
compare the flag bits, rather than comparing a constant. As Joe Perches
pointed out, an earlier patch of mine incorrectly assumed this was a
false-positive warning.

Cc: Joe Perches <joe@perches.com>
Link: https://patchwork.kernel.org/patch/9840289/
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Applied, thank you.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help