Re: [PATCH] ath10: mark PM functions as __maybe_unused
From: Kalle Valo <hidden>
Date: 2017-09-07 11:36:11
Also in:
linux-wireless, lkml
Possibly related (same subject, not in this thread)
- 2017-09-21 · Re: [PATCH] ath10: mark PM functions as __maybe_unused · Kalle Valo <hidden>
- 2017-09-06 · [PATCH] ath10: mark PM functions as __maybe_unused · Arnd Bergmann <arnd@arndb.de>
Arnd Bergmann [off-list ref] writes:
When CONFIG_PM_SLEEP is disabled, we get a compile-time
warning:
drivers/net/wireless/ath/ath10k/pci.c:3417:12: error: 'ath10k_pci_pm_resume' defined but not used [-Werror=unused-function]
static int ath10k_pci_pm_resume(struct device *dev)
^~~~~~~~~~~~~~~~~~~~
drivers/net/wireless/ath/ath10k/pci.c:3401:12: error: 'ath10k_pci_pm_suspend' defined but not used [-Werror=unused-function]
static int ath10k_pci_pm_suspend(struct device *dev)
Rather than fixing the #ifdef, this just marks both functions
as __maybe_unused, which is a more robust way to do this.
Fixes: 32faa3f0ee50 ("ath10k: add the PCI PM core suspend/resume ops")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>Thanks. But the title should have "ath10k:", I'll fix that. -- Kalle Valo