Thread (3 messages) flat view 3 messages, 3 authors, 2017-09-08

Re: [PATCH net v2] rds: Fix incorrect statistics counting

From: Santosh Shilimkar <hidden>
Date: 2017-09-06 16:48:50
Also in: linux-rdma, lkml

On 9/6/2017 9:35 AM, Håkon Bugge wrote:
In rds_send_xmit() there is logic to batch the sends. However, if
another thread has acquired the lock and has incremented the send_gen,
it is considered a race and we yield. The code incrementing the
s_send_lock_queue_raced statistics counter did not count this event
correctly.

This commit counts the race condition correctly.

Changes from v1:
- Removed check for *someone_on_xmit()*
- Fixed incorrect indentation

Signed-off-by: Håkon Bugge <redacted>
Reviewed-by: Knut Omang <redacted>
---
Thanks for the update.
Acked-by: Santosh Shilimkar <redacted>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help