Thread (6 messages) flat view 6 messages, 2 authors, 2017-09-06

Re: hung task in mac80211

From: Johannes Berg <johannes@sipsolutions.net>
Date: 2017-09-06 13:30:15
Also in: linux-wireless, lkml

Possibly related (same subject, not in this thread)

On Wed, 2017-09-06 at 15:27 +0200, Stefano Brivio wrote:
Yes, that was based on the assumption that the initial part of
__ieee80211_start_rx_ba_session() can't really affect the AMPDU
state-machine in any way.
That's not really the point, if that changes that function would have
to move the locking around, and nothing else.

The point is more that code in ieee80211_ba_session_work() could assume
the lock is held across the entire loop, since that's the way it's
written and looks like even with your patch.

So for example replacing the loop of tid = 0..NUM_TIDS-1 with a
list_for_each_entry() would already be unsafe with the dropping if the
list were to require the mutex for locking.

johannes
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help