Thread (6 messages) 6 messages, 4 authors, 2017-09-02

Re: [PATCH 31/31] timer: Switch to testing for .function instead of .data

From: Dmitry Torokhov <hidden>
Date: 2017-09-01 01:06:33
Also in: intel-wired-lan, linux-input, linux-pm, linux-rdma, lkml

On Thu, Aug 31, 2017 at 4:59 PM, Kees Cook [off-list ref] wrote:
On Thu, Aug 31, 2017 at 4:45 PM, Dmitry Torokhov
[off-list ref] wrote:
quoted
On Thu, Aug 31, 2017 at 4:29 PM, Kees Cook [off-list ref] wrote:
quoted
In several places, .data is checked for initialization to gate early
calls to del_timer_sync(). Checking for .function is equally valid, so
switch to this in all callers.
Not seeing the rest of patches it is unclear from the patch
description why this is needed/wanted.
The CC list would have been really giant, but here is the first patch
and the earlier series list:

https://lkml.org/lkml/2017/8/31/904
https://lkml.org/lkml/2017/8/30/760

tl;dr: We're going to switch all struct timer_list callbacks to get
the timer pointer as the argument instead of from the .data field.
This patch is one step in removing open-coded users of the .data
field.
And that is exactly what should have been in the patch description.

FWIW for input bits:

Acked-by: Dmitry Torokhov <redacted>

Thanks.

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help