Thread (2 messages) flat view 2 messages, 2 authors, 2017-09-26

Re: [PATCH net-next] net: speed up skb_rbtree_purge()

From: David Miller <davem@davemloft.net>
Date: 2017-09-26 03:36:12

From: Eric Dumazet <redacted>
Date: Sat, 23 Sep 2017 12:39:12 -0700
From: Eric Dumazet <edumazet@google.com>

As measured in my prior patch ("sch_netem: faster rb tree removal"),
rbtree_postorder_for_each_entry_safe() is nice looking but much slower
than using rb_next() directly, except when tree is small enough
to fit in CPU caches (then the cost is the same)

Also note that there is not even an increase of text size :
$ size net/core/skbuff.o.before net/core/skbuff.o
   text	   data	    bss	    dec	    hex	filename
  40711	   1298	      0	  42009	   a419	net/core/skbuff.o.before
  40711	   1298	      0	  42009	   a419	net/core/skbuff.o


From: Eric Dumazet <edumazet@google.com>
Applied.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help