Thread (23 messages) flat view 23 messages, 4 authors, 2017-09-23

Re: [patch net-next 05/12] net: ipmr: Add MFC offload indication

From: Nikolay Aleksandrov <hidden>
Date: 2017-09-21 11:28:03

On 21/09/17 09:43, Jiri Pirko wrote:
quoted hunk ↗ jump to hunk
From: Yotam Gigi <redacted>

Allow drivers, registered to the fib notification chain indicate whether a
multicast MFC route is offloaded or not, similarly to unicast routes. The
indication of whether a route is offloaded is done using the mfc_flags
field on an mfc_cache struct, and the information is sent to the userspace
via the RTNetlink interface only.

Currently, MFC routes are either offloaded or not, thus there is no need to
add per-VIF offload indication.

Signed-off-by: Yotam Gigi <redacted>
Reviewed-by: Ido Schimmel <redacted>
Signed-off-by: Jiri Pirko <redacted>
---
 include/linux/mroute.h | 1 +
 net/ipv4/ipmr.c        | 3 +++
 2 files changed, 4 insertions(+)
diff --git a/include/linux/mroute.h b/include/linux/mroute.h
index ba5a976..9b64587 100644
--- a/include/linux/mroute.h
+++ b/include/linux/mroute.h
@@ -93,6 +93,7 @@ struct mr_table {
  */
 enum {
 	MFC_STATIC = BIT(0),
+	MFC_OFFLOAD = BIT(1),
 };
It maybe redundant but above this enum is a comment with flag descriptions,
since you're adding a new flag could you also please add a short
description above ?
quoted hunk ↗ jump to hunk
 
 struct mfc_cache_cmp_arg {
diff --git a/net/ipv4/ipmr.c b/net/ipv4/ipmr.c
index 7891d95..6804885 100644
--- a/net/ipv4/ipmr.c
+++ b/net/ipv4/ipmr.c
@@ -2268,6 +2268,9 @@ static int __ipmr_fill_mroute(struct mr_table *mrt, struct sk_buff *skb,
 	    nla_put_u32(skb, RTA_IIF, mrt->vif_table[c->mfc_parent].dev->ifindex) < 0)
 		return -EMSGSIZE;
 
+	if (c->mfc_flags & MFC_OFFLOAD)
+		rtm->rtm_flags |= RTNH_F_OFFLOAD;
+
 	if (!(mp_attr = nla_nest_start(skb, RTA_MULTIPATH)))
 		return -EMSGSIZE;
 
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help