Re: [PATCH net-next 3/4] cxgb4: add support to offload action vlan
From: Jiri Pirko <jiri@resnulli.us>
Date: 2017-09-21 08:55:10
Thu, Sep 21, 2017 at 09:33:36AM CEST, rahul.lakkireddy@chelsio.com wrote:
quoted hunk ↗ jump to hunk
From: Kumar Sanghvi <redacted> Add support for offloading tc-flower flows having vlan actions: pop, push and modify. Signed-off-by: Kumar Sanghvi <redacted> Signed-off-by: Rahul Lakkireddy <redacted> Signed-off-by: Ganesh Goudar <redacted> --- .../net/ethernet/chelsio/cxgb4/cxgb4_tc_flower.c | 43 ++++++++++++++++++++++ 1 file changed, 43 insertions(+)diff --git a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_tc_flower.c b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_tc_flower.c
[...]
+ switch (vlan_action) {
+ case TCA_VLAN_ACT_POP:
+ break;
+ case TCA_VLAN_ACT_PUSH:
+ case TCA_VLAN_ACT_MODIFY:
+ if (proto != ETH_P_8021Q) {
+ netdev_err(dev,
+ "%s: Unsupp. vlan proto\n",Don't wrap this. Also "Unsupp."vs"Unsupported". Please be consistent.
+ __func__);
+ return -EOPNOTSUPP;
+ }
+ break;
+ default:
+ netdev_err(dev, "%s: Unsupported vlan action\n",
+ __func__);
+ return -EOPNOTSUPP;
+ }
} else {
netdev_err(dev, "%s: Unsupported action\n", __func__);
return -EOPNOTSUPP;
--
2.14.1