RE: [PATCH v4 net 2/3] lan78xx: Allow EEPROM write for less than MAX_EEPROM_SIZE

Thanks Sergei, I will update it and submit next version.

- Nisar

 > Hello!

On 09/19/2017 01:02 AM, Nisar Sayed wrote:

quoted

Allow EEPROM write for less than MAX_EEPROM_SIZE

Fixes: 55d7de9de6c3 ("Microchip's LAN7800 family USB 2/3 to
10/100/1000 Ethernet device driver")
Signed-off-by: Nisar Sayed <redacted>
---
  drivers/net/usb/lan78xx.c | 9 ++++-----
  1 file changed, 4 insertions(+), 5 deletions(-)

diff --git a/drivers/net/usb/lan78xx.c b/drivers/net/usb/lan78xx.c
index fcf85ae37435..3292f56ffe02 100644
--- a/drivers/net/usb/lan78xx.c
+++ b/drivers/net/usb/lan78xx.c

@@ -1290,11 +1290,10 @@ static int lan78xx_ethtool_set_eeprom(struct

net_device *netdev,

quoted

  	if (ret)
  		return ret;

-	/* Allow entire eeprom update only */
-	if ((ee->magic == LAN78XX_EEPROM_MAGIC) &&
-	    (ee->offset == 0) &&
-	    (ee->len == 512) &&
-	    (data[0] == EEPROM_INDICATOR))
+	/* Invalid EEPROM_INDICATOR at offset zero will result in fail to

    s/fail/a failure/.

quoted

+	 * load data from EEPROM
+	 */
+	if (ee->magic == LAN78XX_EEPROM_MAGIC)
  		ret = lan78xx_write_raw_eeprom(dev, ee->offset, ee->len,

data);

quoted

  	else if ((ee->magic == LAN78XX_OTP_MAGIC) &&
  		 (ee->offset == 0) &&

MBR, Sergei