Thread (29 messages) flat view 29 messages, 4 authors, 2017-09-20

Re: Latest net-next from GIT panic

From: Paweł Staszewski <hidden>
Date: 2017-09-20 14:05:49

Possibly related (same subject, not in this thread)

Nit much more after adding this patch

https://bugzilla.kernel.org/attachment.cgi?id=258529



W dniu 2017-09-20 o 15:44, Eric Dumazet pisze:
On Wed, 2017-09-20 at 15:39 +0200, Paweł Staszewski wrote:
quoted
W dniu 2017-09-20 o 15:34, Eric Dumazet pisze:
quoted
Could you try this debug patch ?
diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h
index f535779d9dc1dfe36934c2abba4e43d053ac5d6f..1eaa3553a724dc8c048f67b556337072d5addc82 100644
--- a/include/linux/netdevice.h
+++ b/include/linux/netdevice.h
@@ -3331,7 +3331,14 @@ void netdev_run_todo(void);
    */
   static inline void dev_put(struct net_device *dev)
   {
-	this_cpu_dec(*dev->pcpu_refcnt);
+	int __percpu *pref = READ_ONCE(dev->pcpu_refcnt);
+
+	if (!pref) {
+		pr_err("no pcpu_refcnt on dev %p(%s) state %d dismantle %d\n",
+		       dev, dev->name, dev->reg_state, dev->dismantle);
+		BUG();
+	}
+	this_cpu_dec(*pref);
   }
   
   /**

You want me to add this patch to what kernel version ?
currently im after git bisect reset - so mainline stable
Simply us the latest net-next as mentioned in the thread title, thanks.

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help