Thread (10 messages) flat view 10 messages, 4 authors, 2017-09-20

Re: [PATCH,net-next,2/2] tun: enable napi_gro_frags() for TUN/TAP driver

From: Eric Dumazet <hidden>
Date: 2017-09-20 03:16:15

On Tue, 2017-09-19 at 00:34 -0700, Petar Penkov wrote:
Add a TUN/TAP receive mode that exercises the napi_gro_frags()
interface. This mode is available only in TAP mode, as the interface
expects packets with Ethernet headers.

Furthermore, packets follow the layout of the iovec_iter that was
received. The first iovec is the linear data, and every one after the
first is a fragment. If there are more fragments than the max number,
drop the packet. Additionally, invoke eth_get_headlen() to exercise flow
dissector code and to verify that the header resides in the linear data.

The napi_gro_frags() mode requires setting the IFF_NAPI_FRAGS option.
This is imposed because this mode is intended for testing via tools like
syzkaller and packetdrill, and the increased flexibility it provides can
introduce security vulnerabilities.

Signed-off-by: Petar Penkov <redacted>
Cc: Eric Dumazet <edumazet@google.com>
Cc: Mahesh Bandewar <redacted>
Cc: Willem de Bruijn <willemb@google.com>
Cc: davem@davemloft.net
Cc: ppenkov@stanford.edu
---
Again, very nice, thanks a lot Petar.

Acked-by: Eric Dumazet <edumazet@google.com>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help