Re: [PATCH net-next v3 1/4] bpf: add helper bpf_perf_event_read_value for perf event array map

Hi Yonghong,

[auto build test ERROR on net-next/master]

url:    https://github.com/0day-ci/linux/commits/Yonghong-Song/bpf-add-two-helpers-to-read-perf-event-enabled-running-time/20170919-134113
config: m68k-allyesconfig (attached as .config)
compiler: m68k-linux-gcc (GCC) 4.9.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        make.cross ARCH=m68k 

All errors (new ones prefixed by >>):

   kernel/bpf/arraymap.c: In function 'perf_event_fd_array_get_ptr':

quoted

kernel/bpf/arraymap.c:495:6: error: too many arguments to function 'perf_event_read_local'

     if (perf_event_read_local(event, &value, NULL, NULL) == -EOPNOTSUPP)
         ^
   In file included from kernel/bpf/arraymap.c:18:0:
   include/linux/perf_event.h:1290:19: note: declared here
    static inline int perf_event_read_local(struct perf_event *event, u64 *value)
                      ^

vim +/perf_event_read_local +495 kernel/bpf/arraymap.c

   480	
   481	static void *perf_event_fd_array_get_ptr(struct bpf_map *map,
   482						 struct file *map_file, int fd)
   483	{
   484		struct bpf_event_entry *ee;
   485		struct perf_event *event;
   486		struct file *perf_file;
   487		u64 value;
   488	
   489		perf_file = perf_event_get(fd);
   490		if (IS_ERR(perf_file))
   491			return perf_file;
   492	
   493		ee = ERR_PTR(-EOPNOTSUPP);
   494		event = perf_file->private_data;
 > 495		if (perf_event_read_local(event, &value, NULL, NULL) == -EOPNOTSUPP)
   496			goto err_out;
   497	
   498		ee = bpf_event_entry_gen(perf_file, map_file);
   499		if (ee)
   500			return ee;
   501		ee = ERR_PTR(-ENOMEM);
   502	err_out:
   503		fput(perf_file);
   504		return ee;
   505	}
   506	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation